Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Translator code with PHP 8.1 features #648

Merged
merged 3 commits into from
Apr 3, 2022
Merged

Updating Translator code with PHP 8.1 features #648

merged 3 commits into from
Apr 3, 2022

Conversation

msmakouz
Copy link
Member

Q A
Bugfix? ❌
Breaks BC? ✔️
New feature? ❌
Issues #512

@msmakouz msmakouz added this to the 3.0 milestone Mar 31, 2022
@msmakouz msmakouz requested a review from roxblnfk March 31, 2022 19:06
@msmakouz msmakouz self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #648 (0b1dbba) into 3.0 (79fbb2e) will decrease coverage by 0.03%.
The diff coverage is 92.15%.

@@             Coverage Diff              @@
##                3.0     #648      +/-   ##
============================================
- Coverage     82.37%   82.34%   -0.04%     
+ Complexity     5725     5720       -5     
============================================
  Files           667      667              
  Lines         14233    14214      -19     
============================================
- Hits          11725    11705      -20     
- Misses         2508     2509       +1
Impacted Files Coverage Δ
src/Translator/src/Catalogue/NullCache.php 100.00% <ø> (ø)
src/Translator/src/helpers.php 0.00% <0.00%> (ø)
src/Translator/src/Indexer.php 98.24% <92.30%> (-1.76%) ⬇️
src/Translator/src/Catalogue.php 100.00% <100.00%> (ø)
src/Translator/src/Catalogue/CatalogueLoader.php 94.44% <100.00%> (-0.43%) ⬇️
src/Translator/src/Catalogue/CatalogueManager.php 100.00% <100.00%> (ø)
src/Translator/src/Catalogue/RuntimeLoader.php 100.00% <100.00%> (ø)
src/Translator/src/Config/TranslatorConfig.php 100.00% <100.00%> (ø)
src/Translator/src/Exception/LocaleException.php 50.00% <100.00%> (-10.00%) ⬇️
src/Translator/src/Matcher.php 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79fbb2e...0b1dbba. Read the comment docs.

@roxblnfk roxblnfk merged commit 1069002 into spiral:3.0 Apr 3, 2022
@msmakouz msmakouz deleted the maintenance/translator-php-81 branch April 4, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees

@msmakouz msmakouz

Labels
Component: Translator Improvement
Projects
Spiral framework
Status: Done
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msmakouz @roxblnfk